Skip to content

Remove unused method and rename createcommentWithNoAction #9367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 16, 2019

Only one invoke for sendCreateCommentAction but they are all referece comments type and sendCreateCommentAction only handle code, comment, close and reopen. So we can remove it safely.

After that rename createCommentWithNoAction back to createComment is reasonable.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 16, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #9367 into master will increase coverage by <.01%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9367      +/-   ##
==========================================
+ Coverage   41.41%   41.41%   +<.01%     
==========================================
  Files         568      568              
  Lines       74109    74050      -59     
==========================================
- Hits        30689    30670      -19     
+ Misses      39593    39555      -38     
+ Partials     3827     3825       -2
Impacted Files Coverage Δ
models/issue_lock.go 0% <0%> (ø) ⬆️
models/issue_label.go 65.06% <0%> (ø) ⬆️
models/issue_milestone.go 68.01% <0%> (ø) ⬆️
services/pull/review.go 0% <0%> (ø) ⬆️
models/review.go 46.15% <0%> (ø) ⬆️
models/issue_assignees.go 63.35% <100%> (ø) ⬆️
models/issue_xref.go 58.4% <100%> (+0.72%) ⬆️
models/issue.go 52.5% <25%> (ø) ⬆️
models/issue_comment.go 43.38% <60%> (+1.33%) ⬆️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b316a...4826b1a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 16, 2019
@lunny lunny merged commit 43ada65 into go-gitea:master Dec 16, 2019
@lunny lunny deleted the lunny/remove_unused_method branch December 16, 2019 04:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants