Skip to content

Add release cycle to contributing #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 15, 2017

This PR added release cycle section to CONTRIBUTING.md.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Feb 15, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 15, 2017
@tboerger
Copy link
Member

IMHO it's better to place that on the website, no regular user cares about the contributors guideline

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2017
@appleboy
Copy link
Member

appleboy commented Feb 16, 2017

I think to put this section on README.md and official website would be better than CONTRIBUTING.md

@lunny
Copy link
Member Author

lunny commented Feb 16, 2017

I think both are need. First is CONTRIBUTING, user can know the release cycle even if there are a copy of the Gitea code.

@appleboy
Copy link
Member

Could you put the release cycle to readme too? People come here first or somebody who won't contribute to Gitea.

@lunny
Copy link
Member Author

lunny commented Feb 16, 2017

Yes. I will do it another PR after this is merged.

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 16, 2017
@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2017
@lunny
Copy link
Member Author

lunny commented Feb 18, 2017

@tboerger @bkcsoft

@tboerger
Copy link
Member

LGTM

1 similar comment
@bkcsoft
Copy link
Member

bkcsoft commented Feb 19, 2017

LGTM

@lunny lunny merged commit c2c2789 into go-gitea:master Feb 19, 2017
@lunny lunny deleted the lunny/add_release_cycle_to_contributing branch February 19, 2017 15:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants