[Docs] Clarify HTTPS Termination Proxy on Using Reverse Proxy to Enable HTTPS #9491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9491 +/- ##
==========================================
- Coverage 41.53% 41.52% -0.02%
==========================================
Files 572 572
Lines 74752 74752
==========================================
- Hits 31051 31041 -10
- Misses 39850 39863 +13
+ Partials 3851 3848 -3
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
Codecov report seems weird, as only updating docs can decrease coverage only slightly on supposedly random files? |
lafriks
approved these changes
Dec 25, 2019
GiteaBot
added
lgtm/need 1
mrsdizzie
suggested changes
Dec 25, 2019
lunny
approved these changes
Dec 26, 2019
GiteaBot
added
lgtm/done
|
@bagasme Please note @mrsdizzie's comment. |
…xy-note' into docs/https-reverse-termination-proxy-note
|
make L-G-T-M work |
|
It looks like my suggestion wasn't applied from Github but just some of it was retyped. There are still some typos and missing words. |
|
@mrsdizzie Feel free to open new PR with your suggestions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed, enabling HTTPS by reverse proxy often called TLS Termination Proxy. It is optional to also combine it with enabling HTTPS with internal server in case of public instances.
This will close #9354.