-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix create repo bugs #9606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix create repo bugs #9606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jolheiser
commented
Jan 5, 2020
- Errors on repository creation were out of scope of the handling function, so Gitea showed the 500 page (because err was nil).
- When an error occured, templateID was set to int default 0 and the JS was showing template units even though no template was chosen.
Signed-off-by: jolheiser <[email protected]>
lunny
reviewed
Jan 5, 2020
lunny
approved these changes
Jan 5, 2020
lafriks
approved these changes
Jan 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #9606 +/- ##
==========================================
- Coverage 42.17% 42.17% -0.01%
==========================================
Files 578 578
Lines 76065 76066 +1
==========================================
- Hits 32083 32081 -2
- Misses 40001 40002 +1
- Partials 3981 3983 +2
Continue to review full report at Codecov.
|
@jolheiser can you backport this to 1.10.3? |
No, this bug doesn't exist in |
OK :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.