-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Enforce tests don't change files in source tree #9625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feel a little bit too verbose compared to other make command and I don't think that the color use is supported in all shell but it could be merged as it is and change later.
719208b
to
933469e
Compare
Codecov Report
@@ Coverage Diff @@
## master #9625 +/- ##
==========================================
- Coverage 42.27% 42.25% -0.02%
==========================================
Files 610 610
Lines 80370 80372 +2
==========================================
- Hits 33974 33964 -10
- Misses 42217 42229 +12
Partials 4179 4179
Continue to review full report at Codecov.
|
As discussed in #9515 we can add a make test-check statement to ensure that files in the source-tree are not changed following make test or make unit-test-coverage.