Skip to content

Enforce tests don't change files in source tree #9625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 6, 2020

As discussed in #9515 we can add a make test-check statement to ensure that files in the source-tree are not changed following make test or make unit-test-coverage.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2020
Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feel a little bit too verbose compared to other make command and I don't think that the color use is supported in all shell but it could be merged as it is and change later.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2020
@codecov-io
Copy link

codecov-io commented Jan 25, 2020

Codecov Report

Merging #9625 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9625      +/-   ##
==========================================
- Coverage   42.27%   42.25%   -0.02%     
==========================================
  Files         610      610              
  Lines       80370    80372       +2     
==========================================
- Hits        33974    33964      -10     
- Misses      42217    42229      +12     
  Partials     4179     4179
Impacted Files Coverage Δ
models/list_options.go 57.89% <ø> (ø) ⬆️
routers/org/members.go 0% <0%> (ø) ⬆️
routers/repo/commit.go 29.66% <0%> (-0.26%) ⬇️
services/pull/patch.go 62.89% <0%> (-3.15%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/check.go 56.64% <0%> (-2.1%) ⬇️
models/error.go 30.76% <0%> (-0.55%) ⬇️
modules/avatar/avatar.go 54% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933469e...7292e73. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2020
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 26, 2020
@zeripath zeripath merged commit 20d637a into go-gitea:master Jan 26, 2020
@zeripath zeripath deleted the create-test-check branch January 26, 2020 20:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants