-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix #9530: admin auth list make readable and admin auth delete bug fix #9628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
572b7c2
to
b080f7e
Compare
@@ -155,6 +155,7 @@ var ( | |||
microcmdAuthDelete = cli.Command{ | |||
Name: "delete", | |||
Usage: "Delete specific auth source", | |||
Flags: []cli.Flag{idFlag}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of Flags:
entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bagasme The error was because id was not specified as a possible flag for "delete" command thus command such as ./gitea admin auth delete --id 4
resulted in Incorrect Usage: flag provided but not defined: -id
the method for handling deletion of LoginSource
already depends upon id being provided through the --id
flag. But it was not defined in microcmdAuthDelete
adding the Flags: []cli.Flag{idFlag}
makes id to be a possible flag for ./gitea admin auth delete
command.
b080f7e
to
db2a127
Compare
Codecov Report
@@ Coverage Diff @@
## master #9628 +/- ##
==========================================
- Coverage 42.22% 42.16% -0.07%
==========================================
Files 582 583 +1
Lines 77105 77160 +55
==========================================
- Hits 32561 32533 -28
- Misses 40546 40622 +76
- Partials 3998 4005 +7
Continue to review full report at Codecov.
|
Fix for issue #9530.