Skip to content

Fix #9530: admin auth list make readable and admin auth delete bug fix #9628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

shashvat-kedia
Copy link
Contributor

Fix for issue #9530.

@shashvat-kedia shashvat-kedia force-pushed the Fix-9530 branch 2 times, most recently from 572b7c2 to b080f7e Compare January 7, 2020 08:58
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 7, 2020
@@ -155,6 +155,7 @@ var (
microcmdAuthDelete = cli.Command{
Name: "delete",
Usage: "Delete specific auth source",
Flags: []cli.Flag{idFlag},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of Flags: entry?

Copy link
Contributor Author

@shashvat-kedia shashvat-kedia Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bagasme The error was because id was not specified as a possible flag for "delete" command thus command such as ./gitea admin auth delete --id 4 resulted in Incorrect Usage: flag provided but not defined: -id the method for handling deletion of LoginSource already depends upon id being provided through the --id flag. But it was not defined in microcmdAuthDelete adding the Flags: []cli.Flag{idFlag} makes id to be a possible flag for ./gitea admin auth delete command.

@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #9628 into master will decrease coverage by 0.06%.
The diff coverage is 53.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9628      +/-   ##
==========================================
- Coverage   42.22%   42.16%   -0.07%     
==========================================
  Files         582      583       +1     
  Lines       77105    77160      +55     
==========================================
- Hits        32561    32533      -28     
- Misses      40546    40622      +76     
- Partials     3998     4005       +7
Impacted Files Coverage Δ
models/issue_watch.go 61.84% <ø> (-0.5%) ⬇️
services/pull/patch.go 62.65% <ø> (-0.24%) ⬇️
models/wiki.go 100% <ø> (+41.32%) ⬆️
routers/private/serv.go 33.33% <0%> (ø) ⬆️
models/pull.go 46.54% <0%> (ø) ⬆️
routers/repo/issue.go 37.79% <100%> (+0.13%) ⬆️
routers/repo/branch.go 53.07% <26.31%> (-4.59%) ⬇️
routers/repo/pull.go 30.75% <44.44%> (-0.03%) ⬇️
services/wiki/wiki.go 57.08% <57.08%> (ø)
routers/repo/wiki.go 38.88% <80.95%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2a127...e03de7c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2020
@zeripath zeripath added this to the 1.11.0 milestone Jan 7, 2020
@zeripath zeripath merged commit 1e9b3d4 into go-gitea:master Jan 7, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants