Skip to content

Move tracked time api convert to convert package #9665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 11, 2020
Merged

Move tracked time api convert to convert package #9665

merged 8 commits into from
Jan 11, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 9, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 9, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2020
@codecov-io
Copy link

codecov-io commented Jan 10, 2020 •
edited
Loading

Codecov Report

Merging #9665 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9665      +/-   ##
==========================================
- Coverage   42.25%   42.24%   -0.01%     
==========================================
  Files         591      591              
  Lines       78002    78001       -1     
==========================================
- Hits        32958    32952       -6     
- Misses      41002    41008       +6     
+ Partials     4042     4041       -1
Impacted Files Coverage Δ
routers/api/v1/repo/repo.go 69.55% <ø> (-0.04%) ⬇️
models/issue.go 55.02% <100%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbbcad...c61b32b. Read the comment docs.

@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 10, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 4d06d10 into go-gitea:master Jan 11, 2020
@lunny lunny deleted the lunny/move_trackedtime_apiformat branch January 11, 2020 03:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @techknowlogick @guillep2k @gary-kim @GiteaBot