Skip to content

Fix push-to-create #9772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 16, 2020
Merged

Fix push-to-create #9772

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
501d36d
Fix push-to-create
jolheiser Jan 14, 2020
94ade51
Check URL path and service
jolheiser Jan 14, 2020
06aabbb
Merge branch 'master' into push_create_post
jolheiser Jan 14, 2020
d29c824
Merge branch 'master' into push_create_post
jolheiser Jan 15, 2020
229b4de
Merge branch 'master' into push_create_post
jolheiser Jan 15, 2020
2b1d80f
Send dummy payload on receive-pack GET
jolheiser Jan 15, 2020
1064d65
Merge branch 'push_create_post' of github.com:jolheiser/gitea into pu…
jolheiser Jan 15, 2020
6de248f
The space was actually a NUL byte
jolheiser Jan 15, 2020
6cbb2bd
Use real bare repo instead of manufactured payload
jolheiser Jan 15, 2020
9c7ee29
Merge branch 'master' into push_create_post
jolheiser Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion routers/repo/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,12 @@ func HTTP(ctx *context.Context) {
return
}

var isPull bool
var isPull, pushCreate bool
service := ctx.Query("service")
if service == "git-receive-pack" ||
strings.HasSuffix(ctx.Req.URL.Path, "git-receive-pack") {
isPull = false
pushCreate = true
} else if service == "git-upload-pack" ||
strings.HasSuffix(ctx.Req.URL.Path, "git-upload-pack") {
isPull = true
Expand Down Expand Up @@ -282,6 +283,10 @@ func HTTP(ctx *context.Context) {
}

if !repoExist {
if !pushCreate {
ctx.HandleText(http.StatusNotFound, "Repository not found")
return
}
if owner.IsOrganization() && !setting.Repository.EnablePushCreateOrg {
ctx.HandleText(http.StatusForbidden, "Push to create is not enabled for organizations.")
return
Expand Down