Skip to content

Fix signing info on PR view if not logged in #9788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2020
Merged

Fix signing info on PR view if not logged in #9788

merged 2 commits into from
Jan 15, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 15, 2020

Before Fix:

Bildschirmfoto zu 2020-01-15 21-05-22

After Fix:

Bildschirmfoto zu 2020-01-15 21-04-34

@6543
Copy link
Member Author

6543 commented Jan 15, 2020

@zeripath you may have a look at this fix?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2020
@lafriks lafriks added this to the 1.12.0 milestone Jan 15, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 15, 2020
@6543 6543 force-pushed the fix-signing-info branch from 4e08c2c to 5ca5dc0 Compare January 15, 2020 20:10
@lafriks lafriks requested a review from zeripath January 15, 2020 20:10
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2020
zeripath
zeripath approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't realize that unsigned users went here!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5ca5dc0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9788   +/-   ##
=========================================
  Coverage          ?   42.17%           
=========================================
  Files             ?      603           
  Lines             ?    78837           
  Branches          ?        0           
=========================================
  Hits              ?    33246           
  Misses            ?    41519           
  Partials          ?     4072
Impacted Files Coverage Δ
modules/sync/unique_queue.go 53.7% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca5dc0...a1c5be9. Read the comment docs.

@zeripath zeripath changed the title Fix Signing Info on PR View Fix signing info on merge view if not logged in Jan 15, 2020
@zeripath zeripath changed the title Fix signing info on merge view if not logged in Fix signing info on PR view if not logged in Jan 15, 2020
@zeripath zeripath merged commit 665d7e9 into go-gitea:master Jan 15, 2020
@6543 6543 deleted the fix-signing-info branch January 15, 2020 22:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-io @lafriks @zeripath @GiteaBot