Skip to content

Filter locales under 25% #9893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 21, 2020
Merged

Filter locales under 25% #9893

merged 8 commits into from
Jan 21, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 20, 2020

This PR roughly does that by counting line on translation files.

The files that will be removed:

Removing ./options/locale/locale_lt-LT.ini: 290/551
Removing ./options/locale/locale_nb-NO.ini: 226/551
Removing ./options/locale/locale_nn-NO.ini: 123/551
Removing ./options/locale/locale_no-NO.ini: 161/551
Removing ./options/locale/locale_ru-UA.ini: 109/551
Removing ./options/locale/locale_vi-VN.ini: 123/551

I added a wip label because I scratch that on github but it need to be tested a little more.

Fix #9779

@sapk sapk added pr/wip This PR is not ready for review topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Jan 20, 2020
@lafriks
Copy link
Member

lafriks commented Jan 20, 2020

We should also not show language in selection also than if no locale file exists for it

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 20, 2020
@sapk
Copy link
Member Author

sapk commented Jan 20, 2020

@lafriks they aren't in the default list

{
			"en-US", "zh-CN", "zh-HK", "zh-TW", "de-DE", "fr-FR", "nl-NL", "lv-LV",
			"ru-RU", "uk-UA", "ja-JP", "es-ES", "pt-BR", "pl-PL", "bg-BG", "it-IT",
			"fi-FI", "tr-TR", "cs-CZ", "sr-SP", "sv-SE", "ko-KR"}

@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #9893 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9893      +/-   ##
==========================================
- Coverage   42.31%   42.29%   -0.02%     
==========================================
  Files         607      607              
  Lines       79353    79357       +4     
==========================================
- Hits        33577    33567      -10     
- Misses      41634    41647      +13     
- Partials     4142     4143       +1
Impacted Files Coverage Δ
modules/queue/queue_redis.go 1.41% <0%> (-0.02%) ⬇️
models/issue_comment_list.go 73.82% <0%> (-0.8%) ⬇️
services/pull/patch.go 66.03% <0%> (-3.78%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo.go 49.76% <0%> (-0.14%) ⬇️
modules/queue/workerpool.go 43.77% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288b3b9...5975640. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 21, 2020
@sapk sapk removed the pr/wip This PR is not ready for review label Jan 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
@sapk sapk merged commit 99aad09 into go-gitea:master Jan 21, 2020
@sapk sapk deleted the clean-locales branch January 21, 2020 16:26
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter locales under a certain percentage
6 participants