Skip to content

add remote ip to the invalid credentials error message #9918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

bobemoe
Copy link
Contributor

@bobemoe bobemoe commented Jan 21, 2020

Fixes #4565

Very simple, just adds the Remote IP to the "invalid credentials" error message.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2020
@zeripath zeripath added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/miscellaneous and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 21, 2020
@zeripath zeripath added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2020
@techknowlogick
Copy link
Member

techknowlogick commented Jan 21, 2020

I don’t know if this solves the linked error. This provides the IP to the user it doesn’t appear to add it to the logs.

oh wait, nvm. ignore me.

@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #9918 into master will decrease coverage by 0.01%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9918      +/-   ##
=========================================
- Coverage   42.31%   42.3%   -0.02%     
=========================================
  Files         607     607              
  Lines       79357   79352       -5     
=========================================
- Hits        33581   33568      -13     
- Misses      41635   41641       +6     
- Partials     4141    4143       +2
Impacted Files Coverage Δ
modules/webhook/slack.go 27.31% <0%> (+0.56%) ⬆️
models/login_source.go 25.63% <50%> (ø) ⬆️
modules/queue/workerpool.go 41.2% <0%> (-3.01%) ⬇️
services/pull/check.go 56.64% <0%> (-2.1%) ⬇️
models/error.go 30.76% <0%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1865c...e7700b8. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
@techknowlogick techknowlogick merged commit cca13ae into go-gitea:master Jan 21, 2020
@lafriks lafriks added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better logging for failed attempts at repo migration - Brute force possible
6 participants