Remove statements not supported by SQLExpress from migration test databases

[guillep2k]

I'm unable to run make test-mssql-migrations tests in my environment, neither with my old SQL Server 2008R2 or with the SQLExpress 15.0.1900.25 I've just installed in my CentOS 7. The test databases were exported from a modern full-fledged version of MSSQL and they contain some commands that make Express fail (I figure there's no point in addressing 2008R2).

I've edited the files to remove three statements that were incompatible with Express, so the tests PASS in my system:

ALTER DATABASE [gitea] SET TRUSTWORTHY OFF
GO
ALTER DATABASE [gitea] SET HONOR_BROKER_PRIORITY OFF
GO
ALTER DATABASE [gitea] SET DB_CHAINING OFF
GO

AFAIU these statements are defaults and removing them should be innocuous:

• SET TRUSTWORTHY OFF.
• HONOR_BROKER_PRIORITY
• SET DB_CHAINING OFF

PS: I know, I work with very old stuff.... 😢

[codecov-io]

Codecov Report

Merging #9929 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9929      +/-   ##
==========================================
- Coverage   42.27%   42.27%   -0.01%     
==========================================
  Files         608      608              
  Lines       79392    79392              
==========================================
- Hits        33566    33560       -6     
- Misses      41681    41688       +7     
+ Partials     4145     4144       -1

Impacted Files	Coverage Δ
services/pull/temp_repo.go	31.62% <0%> (-2.57%)	⬇️
services/pull/check.go	56.64% <0%> (-2.1%)	⬇️
services/pull/patch.go	66.03% <0%> (-1.89%)	⬇️
models/error.go	30.76% <0%> (-0.55%)	⬇️
models/repo.go	49.76% <0%> (-0.14%)	⬇️
services/pull/pull.go	36.12% <0%> (+3.04%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d2a66...58479e9. Read the comment docs.

[bagasme]

Why gzipped SQL scripts?

[guillep2k]

Why gzipped SQL scripts?

They were originally gzipped. I just decompressed, edited and recompressed.

[zeripath]

They're gzipped because otherwise they're very large and they're not really code or meant to be updated.