This repository was archived by the owner on Jun 8, 2019. It is now read-only.
duplicated of json field #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Is the change compatible with Github's API? |
Just look some lines above, the JSON field is already taken by the tag name. |
sapk
suggested changes
Apr 14, 2017
There was a problem hiding this comment.
As described here https://developer.github.com/v3/repos/releases/. It is TagName that should be rename and not title.
gitea/release.go
Outdated
| @@ -16,7 +16,7 @@ type Release struct { | |||
| ID int64 `json:"id"` | |||
| TagName string `json:"name"` | |||
gitea/release.go
Outdated
| @@ -16,7 +16,7 @@ type Release struct { | |||
| ID int64 `json:"id"` | |||
| TagName string `json:"name"` | |||
| Target string `json:"target_commitish"` | |||
| Title string `json:"name"` | |||
| Title string `json:"title"` | |||
Signed-off-by: Bo-Yi Wu <[email protected]>
|
First LGTM ^^ |
|
On Sat, Apr 15, 2017 at 08:49:12AM -0700, Antoine GIRARD wrote:
First LGTM ^^
Does it mean you're a maintainer now ? Because I don't see you
yet in the MAINTAINERS file ?
Take my LGTM if yours isn't good (I'm trusting you)
|
|
@sapk Could you update this https://github.com/go-gitea/go-sdk/blob/master/MAINTAINERS file in all repository of Gitea organization？ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/go-gitea/go-sdk/blob/master/gitea/release.go#L17-L19