Skip to content
This repository was archived by the owner on Jun 8, 2019. It is now read-only.

Modified assignees field in issue struct for preperation of go-gitea/gitea#1884 #97

Merged
merged 3 commits into from
Mar 6, 2018

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Mar 3, 2018

I'm currently implementing go-gitea/gitea#1884, this pr should be merged before the one in the gitea project.

@thehowl
Copy link

thehowl commented Mar 3, 2018

Wouldn't this break the API?

@kolaente
Copy link
Member Author

kolaente commented Mar 3, 2018

Yes. But is there another possibility? These are breaking changes.

@thehowl
Copy link

thehowl commented Mar 3, 2018

I'd suggest keeping the assignee and having ExtraAssignees, being an array. Assignee will be the first, ExtraAssignees will be the rest.

@kolaente
Copy link
Member Author

kolaente commented Mar 3, 2018

Honestly, this sound like a hack, not a proper solution. We could keep Assignee for a limited amount of time (and setting it to something like "This is deprecated. Use Assignees", but I'd prefer not to do this), but if we want to make it clean, we have to delete Assignee in favour of Assignees (array).

@thehowl
Copy link

thehowl commented Mar 3, 2018

Sure, that sounds more ideal. Although, breaking changes in the API before v2 are a big NO from me.

@lunny
Copy link
Member

lunny commented Mar 4, 2018

@kolaente you can add a migration on gitea repository.

@lunny
Copy link
Member

lunny commented Mar 4, 2018

And you can keep Assignee as the first assignees for keeping compitable

@kolaente
Copy link
Member Author

kolaente commented Mar 5, 2018

Ok, so here's what I do: I'll add Assignees (will be an array) and keep Assignee (single user object). Assignee will contain the first assignee, Assignees will contain all assignees, including the first one.

@appleboy appleboy merged commit fa91af7 into go-gitea:master Mar 6, 2018
@kolaente
Copy link
Member Author

kolaente commented Mar 7, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants