Add visible field to schema #1043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhuiyeh
force-pushed
the
add-visible-field-to-schema
branch
from
3af6107 to
c7a82aa
Compare
lance6716
reviewed
Jun 6, 2025
| // - "8.0.25-0ubuntu0.20.04.1" | ||
| func isMySQL8OrAbove(version string) bool { | ||
|
|
||
| // Extract the version number before any additional info (like "-log", "-ubuntu", etc.) |
There was a problem hiding this comment.
CompareServerVersions has been updated, the comment says "ignoring anything past - in version.". I think you can directly use it.
| @@ -338,6 +391,14 @@ func (ta *Table) fetchIndexes(conn mysql.Executer) error { | |||
| colName, _ := r.GetString(i, 4) | |||
| currentIndex.AddColumn(colName, cardinality) | |||
| currentIndex.NoneUnique, _ = r.GetUint(i, 1) | |||
|
|
|||
| // Only set to false if explicitly marked as invisible | |||
| if hasInvisibleIndex { | |||
There was a problem hiding this comment.
nit: considering MariaDB use case, we can check the columns returned by show index to know if there are Visible column.
dveeden
reviewed
Jun 6, 2025
| } | ||
|
|
||
| func hasInvisibleIndexSupport(conn mysql.Executer) bool { | ||
| versionQuery := "SELECT VERSION()" |
There was a problem hiding this comment.
Maybe we can use the version from the handshake and skip the extra roundtrip?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature targeting MySQL version 8 and above, where the concept of invisible indexes has been introduced. Specifically, this PR adds a Visible field to the schema.Index struct, allowing users to easily filter out invisible indexes.
We encountered an issue with ghostferry where an invisible index was mistakenly selected as the shardingKeyIndexName. To address this, we initially applied a patch directly to the ghostferry project, as documented in ghostferry PR #383. This current PR seeks to integrate those changes into the upstream codebase for broader applicability. Part of Shopify/ghostferry#384.