navigation_astar: Migrate to TileMapLayer and various cleanups #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the confusing use of Tile.OBSTACLE. The tile enum is mostly used for atlas coordinates but in this case it is compared with the source id which only happens to be zero as well.
This makes it more obvious how to set cells in larger tilesets where the second position is not zero. It also removes the constant OBSTACLE which is unused since the last commit.
Using it in this example is more complex (as the border has no cells) but it's good to know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
besides the TileMapLayer migration I performed a few cleanups and added some comments which might be helpful.
Best,
Simon