Fix "Parse message failed" error in WebRTC Signaling Demo Project #1209
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON.parse_string will always return float for numeric values
Calinou
reviewed
Jun 6, 2025
| @@ -207,7 +207,7 @@ func _parse_msg(peer: Peer) -> bool: | |||
| if typeof(parsed) != TYPE_DICTIONARY or not parsed.has("type") or not parsed.has("id") or \ | |||
| typeof(parsed.get("data")) != TYPE_STRING: | |||
| return false | |||
| if not str(parsed.type).is_valid_int() or not str(parsed.id).is_valid_int(): | |||
| if not typeof(parsed.type) == Variant.Type.TYPE_FLOAT or not typeof(parsed.id) == Variant.Type.TYPE_FLOAT: | |||
There was a problem hiding this comment.
I think this can be simplified to the following:
Suggested change
| if not typeof(parsed.type) == Variant.Type.TYPE_FLOAT or not typeof(parsed.id) == Variant.Type.TYPE_FLOAT: | |
| if parsed.type is not float or parsed.id is not float: |
If not, this can be simplified to:
if not typeof(parsed.type) == TYPE_FLOAT or not typeof(parsed.id) == TYPE_FLOAT:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _parse_msg method type-checks parsed JSON numeric values to require integers, however JSON.parse_string always returns floats, leading to a "Parse message failed" error when running the demo.
Issue link: godotengine/godot#103374