APIs for pull requests

[yurivict]

Particularly these commands are desired:

• /api/v1/{user}/{repo}/pulls?status={open/closed}&id={id} - retrieves the list of pull requests (or one pull request)
• /api/v1/{user}/{repo}/pull/{num}/files - retrieves the list of affected files for the pull request
• /api/v1/{user}/{repo}/pull/{num}/diff - retrieves the diff file for the pull request
• /api/v1/{user}/{repo}/pull/{num}/comments - retrieves the list of comments
• /api/v1/{user}/{repo}/pull/{num}/comment-submit - PUT submits a new comment

[romanresh]

Besides enumerated commands, we use the following PR API in GitLab:

1. Accept pull request via API
2. Reassign pull request
3. Create comment in pull request

We'd like to migrate to Gogs from Gitlab, but these api commands are required in our infrastructure (PR are accepted via an external utility).

[kmadel]

I just wanted to mention that I have written a Gogs Plugin for Jenkins to support Pipeline Multibranch and Org Scanning (auto creates project folders for repos and Pipeline projects for branches that have a Jenkinsfile in them). Initial release is available here: https://github.com/kmadel/gogs-branch-source-plugin/releases/tag/v0.1-alpha

The biggest missing features is support for Pull Requests. Even without a webhook or a Rest API to interact with them - is there anyway to interact with PRs via plain vanialla Git?

Thanks for the awesome work!

[kmadel]

By the way, I would like to mention that I believe Pull Requests should be able to be retrieved the same way that repo branches are (and the way GitHub does it):

GET /repos/:owner/:repo/pulls

And with at least the 'state' parameter to filter:
state string Either open, closed, or all to filter by state. Default: open

[lstahlman]

@unknown are you already working on this in conjunction with #2246? If not, I would like to help out.

[unknwon]

@lstahlman OK, go ahead.

[lstahlman]

Thanks!

[hhenkel]

One implementing the API should probably orientate himself at this github api?

[lstahlman]

That makes sense. I think most of the features requested here fit with that api, though some are dependent on related features that are still in progress (e.g., comments API).

[kmadel]

I also wanted to mention (and please correct me if I am wrong), but I don't believe it is even currently possible to get a list of Pull Request issues.

GET /repos/:owner/:repo/issues does not allow passing in the Issue option to include pull requests per https://github.com/gogits/gogs/blob/master/routers/api/v1/repo/issue.go#L19