Skip to content

ssh: fix data race in dh group exchange sha256 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ssh: fix data race in dh group exchange sha256 #126

wants to merge 1 commit into from

Conversation

breml
Copy link
Contributor

@breml breml commented Mar 4, 2020

@breml breml mentioned this pull request Mar 4, 2020
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: 269c5f1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/222078 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@breml breml force-pushed the fix-data-race-ghgexsha branch from 269c5f1 to 6a382af Compare March 5, 2020 20:38
@gopherbot
Copy link
Contributor

This PR (HEAD: 6a382af) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/222078 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Lucas Bremgartner:

Patch Set 2:

(2 comments)

Thanks for the review, I addressed both items and I updated the CR.

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 2: Run-TryBot+1 Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=4baa015c

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@breml breml force-pushed the fix-data-race-ghgexsha branch from 6a382af to 8cb2460 Compare March 6, 2020 19:01
@gopherbot
Copy link
Contributor

This PR (HEAD: 8cb2460) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/222078 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Lucas Bremgartner:

Patch Set 2:

(1 comment)

Updated the comment.

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 3: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=721a2a73

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/222078.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 17, 2020
@breml @hanwen
ssh: fix data race in dh group exchange sha256
1b76d66 
Fixes golang/go#37607

Change-Id: Iedf6522ec9b9a676ac51c054407a6aef894885f5
GitHub-Last-Rev: 8cb2460
GitHub-Pull-Request: #126
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/222078
Reviewed-by: Han-Wen Nienhuys <[email protected]>
Run-TryBot: Han-Wen Nienhuys <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/222078 has been merged.

@gopherbot gopherbot closed this Mar 17, 2020
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 28, 2022
@breml @hanwen
ssh: fix data race in dh group exchange sha256
9943053 
Fixes golang/go#37607

Change-Id: Iedf6522ec9b9a676ac51c054407a6aef894885f5
GitHub-Last-Rev: 8cb2460c59d2e32bc3f0480bcd7867a113361c67
GitHub-Pull-Request: golang/crypto#126
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/222078
Reviewed-by: Han-Wen Nienhuys <[email protected]>
Run-TryBot: Han-Wen Nienhuys <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 29, 2022
@breml @hanwen
ssh: fix data race in dh group exchange sha256
4e3eed2 
Fixes golang/go#37607

Change-Id: Iedf6522ec9b9a676ac51c054407a6aef894885f5
GitHub-Last-Rev: 8cb2460c59d2e32bc3f0480bcd7867a113361c67
GitHub-Pull-Request: golang/crypto#126
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/222078
Reviewed-by: Han-Wen Nienhuys <[email protected]>
Run-TryBot: Han-Wen Nienhuys <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 29, 2022
@breml @hanwen
ssh: fix data race in dh group exchange sha256
dc3bac8 
Fixes golang/go#37607

Change-Id: Iedf6522ec9b9a676ac51c054407a6aef894885f5
GitHub-Last-Rev: 8cb2460c59d2e32bc3f0480bcd7867a113361c67
GitHub-Pull-Request: golang/crypto#126
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/222078
Reviewed-by: Han-Wen Nienhuys <[email protected]>
Run-TryBot: Han-Wen Nienhuys <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this pull request Feb 16, 2023
@breml @hanwen
ssh: fix data race in dh group exchange sha256
fb6497c 
Fixes golang/go#37607

Change-Id: Iedf6522ec9b9a676ac51c054407a6aef894885f5
GitHub-Last-Rev: 8cb2460c59d2e32bc3f0480bcd7867a113361c67
GitHub-Pull-Request: golang/crypto#126
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/222078
Reviewed-by: Han-Wen Nienhuys <[email protected]>
Run-TryBot: Han-Wen Nienhuys <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
BiiChris pushed a commit to BiiChris/crypto that referenced this pull request Sep 15, 2023
@breml @hanwen
ssh: fix data race in dh group exchange sha256
ea1c1b6 
Fixes golang/go#37607

Change-Id: Iedf6522ec9b9a676ac51c054407a6aef894885f5
GitHub-Last-Rev: 8cb2460
GitHub-Pull-Request: golang#126
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/222078
Reviewed-by: Han-Wen Nienhuys <[email protected]>
Run-TryBot: Han-Wen Nienhuys <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
desdeel2d0m added a commit to desdeel2d0m/crypto that referenced this pull request Jul 1, 2024
@desdeel2d0m @hanwen
ssh: fix data race in dh group exchange sha256
01908a4 
Fixes golang/go#37607

Change-Id: Iedf6522ec9b9a676ac51c054407a6aef894885f5
GitHub-Last-Rev: 8cb2460c59d2e32bc3f0480bcd7867a113361c67
GitHub-Pull-Request: golang/crypto#126
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/222078
Reviewed-by: Han-Wen Nienhuys <[email protected]>
Run-TryBot: Han-Wen Nienhuys <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/crypto/ssh: data race in diffie-hellman-group-exchange-sha256
3 participants
@breml @gopherbot @googlebot