ssh: fix public key and cert authentication compatibility with old clients #261
Conversation
|
This PR (HEAD: 964601a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/504796 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/504796. |
drakkan
force-pushed
the
ssh-sha2-compat
branch
2 times, most recently
from
cae0660 to
ad2f81d
Compare
After adding support for rsa-sha2-256/512 on server side some edge cases started to arise with old clients: 1) public key authentication with gpg-agent < 2.2.6 fails because we receive ssh-rsa as signature format and rsa-sha2-256 or rsa-sha2-512 as algorithm. This is a bug in gpg-agent fixed in this commit: gpg/gnupg@80b775b 2) certificate authentication fails with OpenSSH 7.2-7.7 because we receive [email protected] as algorithm and rsa-sha2-256 or rsa-sha2-512 as signature format. This is a more scoped version of CL 412854, with this patch we only allow the edge cases observed and not any possible variant. This patch is tested with every version of OpenSSH from 7.1 to 7.9. Fixes golang/go#53391
|
This PR (HEAD: 4abd197) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/504796 to see it. Tip: You can toggle comments from me using the |
|
Message from Nicola Murino: Patch Set 2: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/504796. |
|
@drakkan Why has this issue been closed? |
I sent an updated CL https://go-review.googlesource.com/c/crypto/+/506835 I hope this one can be merged |
|
@jakule @stanhu please also check this CL https://go-review.googlesource.com/c/crypto/+/506837 should ensure that incompatibilities with ssh cli are caught sooner |
after adding support for rsa-sha2-256/512 on server side some edge cases started to arise with old clients:
gpg/gnupg@80b775b
This is a more scoped version of:
https://go-review.googlesource.com/c/crypto/+/412854
with this patch we only allow the edge cases observed and not any possible variant.
I have compiled from source and tested every version of OpenSSH from 7.1 to 7.9