Skip to content

x/tools/gopls: ChangeSignature: OOB panic in inline.updateCalleeParams (mismatched syntactic/semantic params) #73913

Open
@adonovan

Description

@adonovan
#!stacks
"goPanicIndex" && "updateCalleeParams.func1"

Issue created by stacks.

func updateCalleeParams(calleeDecl *ast.FuncDecl, params []*parameter) {
...
	filterParams := func(field *ast.Field) {
...
			for _, id := range field.Names {
				if pinfo := params[paramIdx]; pinfo != nil { <--- panic

(Similar to #73912, but a distinct crash.)

This stack uzSaXQ was reported by telemetry:

golang.org/x/tools/[email protected] go1.24.3 darwin/arm64 other,vscode (1)

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.gopls/telemetry-wins

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions