Skip to content

cmd/go: the "build_plugin_non_main" test case cannot pass for linux/mips64le. #42475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

cmd/go: the "build_plugin_non_main" test case cannot pass for linux/mips64le. #42475

wants to merge 1 commit into from

Conversation

XiaodongLoong
Copy link
Contributor

@XiaodongLoong XiaodongLoong commented Nov 10, 2020

Fixes: #42474

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 10, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 23ebfbe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/268737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/268737.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 7c5ad58) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/268737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 9dcc5c9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/268737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 759d2ef) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/268737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/268737.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: f897775) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/268737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 948d017) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/268737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 7: Run-TryBot+1 Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/268737.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 7:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=4ff93645


Please don’t reply on this GitHub thread. Visit golang.org/cl/268737.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 7: Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/268737.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 7: TryBot-Result+1

SlowBots are happy.
SlowBot builds that ran:

  • linux-amd64-nocgo

Please don’t reply on this GitHub thread. Visit golang.org/cl/268737.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 12, 2020
…t support -buildmode=plugin

Fixes #42474

Change-Id: I1550b44b92cd272854e2f17493245a14e3d39f41
GitHub-Last-Rev: 948d017
GitHub-Pull-Request: #42475
Reviewed-on: https://go-review.googlesource.com/c/go/+/268737
Reviewed-by: Bryan C. Mills <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
Trust: Jay Conrod <[email protected]>
@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/268737.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/268737 has been merged.

@gopherbot gopherbot closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/go: the "build_plugin_non_main" test case cannot pass for linux/mips64le port
2 participants