-
Notifications
You must be signed in to change notification settings - Fork 18.2k
cmd/go: the "build_plugin_non_main" test case cannot pass for linux/mips64le. #42475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 23ebfbe) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/268737 to see it. Tip: You can toggle comments from me using the |
Message from Jay Conrod: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/268737. |
This PR (HEAD: 7c5ad58) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/268737 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 9dcc5c9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/268737 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 759d2ef) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/268737 to see it. Tip: You can toggle comments from me using the |
Message from Jay Conrod: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/268737. |
This PR (HEAD: f897775) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/268737 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 948d017) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/268737 to see it. Tip: You can toggle comments from me using the |
Message from Bryan C. Mills: Patch Set 7: Run-TryBot+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/268737. |
Message from Go Bot: Patch Set 7: SlowBots beginning. Status page: https://farmer.golang.org/try?commit=4ff93645 Please don’t reply on this GitHub thread. Visit golang.org/cl/268737. |
Message from Jay Conrod: Patch Set 7: Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/268737. |
Message from Go Bot: Patch Set 7: TryBot-Result+1 SlowBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/268737. |
…t support -buildmode=plugin Fixes #42474 Change-Id: I1550b44b92cd272854e2f17493245a14e3d39f41 GitHub-Last-Rev: 948d017 GitHub-Pull-Request: #42475 Reviewed-on: https://go-review.googlesource.com/c/go/+/268737 Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Jay Conrod <[email protected]> Trust: Jay Conrod <[email protected]>
Message from Bryan C. Mills: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/268737. |
This PR is being closed because golang.org/cl/268737 has been merged. |
Fixes: #42474