all: fix go vet warnings #133
Closed
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http2/h2c/h2c_test.go:27:19: golang.org/x/net/http2.Setting composite literal uses unkeyed fields webdav/prop_test.go:152:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:153:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:191:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:202:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:217:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:227:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:241:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:251:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:496:23: encoding/xml.Name composite literal uses unkeyed fields http2/transport_test.go:5310:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5317:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5660:3: unreachable code
|
This PR (HEAD: a19dcea) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/406454 to see it. Tip: You can toggle comments from me using the |
|
Message from Dan Kortschak: Patch Set 1: Run-TryBot+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/406454. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/406454. |
|
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/406454. |
|
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/406454. |
gopherbot
pushed a commit
that referenced
this pull request
May 16, 2022
http2/h2c/h2c_test.go:27:19: golang.org/x/net/http2.Setting composite literal uses unkeyed fields webdav/prop_test.go:152:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:153:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:191:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:202:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:217:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:227:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:241:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:251:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:496:23: encoding/xml.Name composite literal uses unkeyed fields http2/transport_test.go:5310:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5317:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5660:3: unreachable code Change-Id: I8dc72b976d05dc96ae18d73660c83fc9a5584ce1 GitHub-Last-Rev: a19dcea GitHub-Pull-Request: #133 Reviewed-on: https://go-review.googlesource.com/c/net/+/406454 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Dan Kortschak <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Dan Kortschak <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
|
This PR is being closed because golang.org/cl/406454 has been merged. |
dteh
pushed a commit
to dteh/fhttp
that referenced
this pull request
Jun 22, 2022
http2/h2c/h2c_test.go:27:19: golang.org/x/net/http2.Setting composite literal uses unkeyed fields webdav/prop_test.go:152:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:153:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:191:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:202:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:217:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:227:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:241:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:251:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:496:23: encoding/xml.Name composite literal uses unkeyed fields http2/transport_test.go:5310:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5317:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5660:3: unreachable code Change-Id: I8dc72b976d05dc96ae18d73660c83fc9a5584ce1 GitHub-Last-Rev: a19dceaf92b79bb87237a52e828b858eab5034d1 GitHub-Pull-Request: golang/net#133 Reviewed-on: https://go-review.googlesource.com/c/net/+/406454 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Dan Kortschak <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Dan Kortschak <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
WeiminShang
added a commit
to WeiminShang/net
that referenced
this pull request
Nov 16, 2022
http2/h2c/h2c_test.go:27:19: golang.org/x/net/http2.Setting composite literal uses unkeyed fields webdav/prop_test.go:152:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:153:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:191:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:202:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:217:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:227:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:241:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:251:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:496:23: encoding/xml.Name composite literal uses unkeyed fields http2/transport_test.go:5310:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5317:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5660:3: unreachable code Change-Id: I8dc72b976d05dc96ae18d73660c83fc9a5584ce1 GitHub-Last-Rev: a19dceaf92b79bb87237a52e828b858eab5034d1 GitHub-Pull-Request: golang/net#133 Reviewed-on: https://go-review.googlesource.com/c/net/+/406454 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Dan Kortschak <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Dan Kortschak <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
dt-eric-lefevreardant
pushed a commit
to DiliTrust/go-webdav
that referenced
this pull request
Mar 11, 2025
http2/h2c/h2c_test.go:27:19: golang.org/x/net/http2.Setting composite literal uses unkeyed fields webdav/prop_test.go:152:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:153:5: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:191:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:202:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:217:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:227:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:241:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:251:23: encoding/xml.Name composite literal uses unkeyed fields webdav/prop_test.go:496:23: encoding/xml.Name composite literal uses unkeyed fields http2/transport_test.go:5310:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5317:5: call to (*T).Fatal from a non-test goroutine http2/transport_test.go:5660:3: unreachable code Change-Id: I8dc72b976d05dc96ae18d73660c83fc9a5584ce1 GitHub-Last-Rev: a19dceaf92b79bb87237a52e828b858eab5034d1 GitHub-Pull-Request: golang/net#133 Reviewed-on: https://go-review.googlesource.com/c/net/+/406454 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Dan Kortschak <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Dan Kortschak <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http2/h2c/h2c_test.go:27:19: golang.org/x/net/http2.Setting composite literal uses unkeyed fields
webdav/prop_test.go:152:5: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:153:5: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:191:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:202:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:217:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:227:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:241:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:251:23: encoding/xml.Name composite literal uses unkeyed fields
webdav/prop_test.go:496:23: encoding/xml.Name composite literal uses unkeyed fields
http2/transport_test.go:5310:5: call to (*T).Fatal from a non-test goroutine
http2/transport_test.go:5317:5: call to (*T).Fatal from a non-test goroutine
http2/transport_test.go:5660:3: unreachable code