dns/dnsmessage: use map[string]uint16 instead of map[string]int #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mateusz834 wants to merge 1 commit into golang:master from mateusz834:dnsmessage-uint16

+25 −25

Member

mateusz834 commented Sep 17, 2023 •

edited

Loading

The compression pointer is limited to 14 bits, so there is no
need to use int, uint16 is fine.


          dns/dnsmessage: use map[string]uint16 instead of map[string]int

e04b451

Contributor

gopherbot commented Sep 17, 2023

This PR (HEAD: e04b451) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/528955.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Sep 17, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Mateusz Poliwczak:

Patch Set 1: Commit-Queue+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Mateusz Poliwczak:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Go LUCI:

Patch Set 1:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Mateusz Poliwczak:

Patch Set 1: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Mateusz Poliwczak:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Gopher Robot:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 17, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 18, 2023

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 18, 2023

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-18T22:34:24Z","revision":"8f8f41776b9d90db7fe4d7991b2e6368d24f8477"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 18, 2023

Message from Ian Lance Taylor:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 18, 2023

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 18, 2023

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/528955.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          dns/dnsmessage: use map[string]uint16 instead of map[string]int

7c40cbd

The compression pointer is limited to 14 bits, so there is no
need to use int, uint16 is fine.

Change-Id: I2276cbf63761e26a7e8590f0337930db87895ea5
GitHub-Last-Rev: e04b451
GitHub-Pull-Request: #192
Reviewed-on: https://go-review.googlesource.com/c/net/+/528955
Reviewed-by: Matthew Dempsky <[email protected]>
Run-TryBot: Mateusz Poliwczak <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Contributor

gopherbot commented Sep 20, 2023

This PR is being closed because golang.org/cl/528955 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet