Skip to content

Add id.adform.com to broken providers list #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add id.adform.com to broken providers list #353

wants to merge 1 commit into from

Conversation

tdabasinskas
Copy link

@tdabasinskas tdabasinskas commented Dec 20, 2018

Even id.adform.com provider supports client credentials passed via Basic auth HTTP header, if the client_id contains special symbols, they are not properly decoded. Adding the provider to the broken auth header providers list to make sure the credentials are passed via body and are parsed correctly.

Even https://id.adform.com supports client credentials passed via Basic auth HTTP header, if the client_id contains special symbols, they are not properly decoded. Adding the provider to the broken auth header providers list to make sure the credentials are passed via body and are parsed correctly.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tdabasinskas
Copy link
Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@gopherbot
Copy link
Contributor

This PR (HEAD: 8ddbc4b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/155238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155238.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Julie Qiu:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/155238.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/155238 has been abandoned.

@gopherbot gopherbot closed this Jan 15, 2019
gopherbot pushed a commit that referenced this pull request Feb 11, 2019
Instead of maintaining a global map of which OAuth2 servers do which
auth style and/or requiring the user to tell us, just try both ways
and remember which way worked. But if users want to tell us in the
Endpoint, this CL also add Endpoint.AuthStyle.

Fixes #111
Fixes #365
Fixes #362
Fixes #357
Fixes #353
Fixes #345
Fixes #326
Fixes #352
Fixes #268
Fixes https://go-review.googlesource.com/c/oauth2/+/58510
(... and surely many more ...)

Change-Id: I7b4d98ba1900ee2d3e11e629316b0bf867f7d237
Reviewed-on: https://go-review.googlesource.com/c/157820
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Ross Light <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants