-
Notifications
You must be signed in to change notification settings - Fork 1k
Add id.adform.com to broken providers list #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Even https://id.adform.com supports client credentials passed via Basic auth HTTP header, if the client_id contains special symbols, they are not properly decoded. Adding the provider to the broken auth header providers list to make sure the credentials are passed via body and are parsed correctly.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it |
CLAs look good, thanks! |
This PR (HEAD: 8ddbc4b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/155238 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/155238. |
Message from Julie Qiu: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/155238. |
This PR is being closed because golang.org/cl/155238 has been abandoned. |
Instead of maintaining a global map of which OAuth2 servers do which auth style and/or requiring the user to tell us, just try both ways and remember which way worked. But if users want to tell us in the Endpoint, this CL also add Endpoint.AuthStyle. Fixes #111 Fixes #365 Fixes #362 Fixes #357 Fixes #353 Fixes #345 Fixes #326 Fixes #352 Fixes #268 Fixes https://go-review.googlesource.com/c/oauth2/+/58510 (... and surely many more ...) Change-Id: I7b4d98ba1900ee2d3e11e629316b0bf867f7d237 Reviewed-on: https://go-review.googlesource.com/c/157820 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ross Light <[email protected]>
Even id.adform.com provider supports client credentials passed via Basic auth HTTP header, if the client_id contains special symbols, they are not properly decoded. Adding the provider to the broken auth header providers list to make sure the credentials are passed via body and are parsed correctly.