-
Notifications
You must be signed in to change notification settings - Fork 1k
clientcredentials: allow override of grant_type #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 51f4c98) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/158517 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
Message from Brad Fitzpatrick: Patch Set 1: Please add a test in the existing test file. Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
This PR (HEAD: 13106db) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/158517 to see it. Tip: You can toggle comments from me using the |
Message from Tom Payne: Patch Set 2: Thanks for the feedback. Test added. Are any other changes needed? Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
Message from Brad Fitzpatrick: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
This PR (HEAD: 0e6f85e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/158517 to see it. Tip: You can toggle comments from me using the |
Message from Tom Payne: Patch Set 4: Test added, as requested. Possibly a new record for test/code ratio: 38 lines of test for 21 characters of change :) Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=65d58757 Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/158517. |
Password-based authentication to the [Keycloak](https://www.keycloak.org/) API requires `grant_type` to be `password`. It would be very helpful if `golang.org/x/oauth2` could be used for this, and all's that missing is the ability to override `grant_type`. Fixes #283 Change-Id: I439dccb3e57042571ad92f115442ae1b7d59d4e0 GitHub-Last-Rev: 0e6f85e GitHub-Pull-Request: #363 Reviewed-on: https://go-review.googlesource.com/c/158517 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
This PR is being closed because golang.org/cl/158517 has been merged. |
Password-based authentication to the Keycloak API requires
grant_type
to bepassword
. It would be very helpful ifgolang.org/x/oauth2
could be used for this, and all's that missing is the ability to overridegrant_type
.Fixes #283