Skip to content

unix: define PerfBitWriteBackward #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

unix: define PerfBitWriteBackward #149

wants to merge 1 commit into from
+2 −0

Conversation

eiffel-fl
Copy link

@eiffel-fl eiffel-fl commented Mar 1, 2023 •
edited
Loading

No description provided.

@google-cla
Copy link

google-cla bot commented Mar 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@eiffel-fl eiffel-fl force-pushed the francis/perf-bit-write-backward branch 2 times, most recently from 6a9010c to 6a93787 Compare March 3, 2023 14:48
@gopherbot
Copy link
Contributor

This PR (HEAD: 6a93787) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/473135 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/473135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tobias Klauser:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473135.
After addressing review feedback, remember to publish your drafts!

unix: define PerfBitWriteBackward
43383aa 
This bit, introduced in kernel 4.7, is used to indicate a perf ring buffer will
be written backward [1].
This is mainly used for overwritable perf ring buffer.

Suggested-by: Lorenz Bauer <[email protected]>
Signed-off-by: Francis Laniel <[email protected]>
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9ecda41acb97
@eiffel-fl eiffel-fl force-pushed the francis/perf-bit-write-backward branch from 6a93787 to 43383aa Compare March 3, 2023 17:13
@eiffel-fl eiffel-fl changed the title unix: Define PerfBitWriteBackward. unix: define PerfBitWriteBackward Mar 3, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: 43383aa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/473135 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Uncyclo page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tobias Klauser:

Patch Set 2: Code-Review+2

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473135.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 4, 2023
@gopherbot
unix: define PerfBitWriteBackward
c7a1bf9 
Change-Id: I0b95006039b4efcd0094ba96281100abeafc993e
GitHub-Last-Rev: 43383aa
GitHub-Pull-Request: #149
Reviewed-on: https://go-review.googlesource.com/c/sys/+/473135
Reviewed-by: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Tobias Klauser <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/473135 has been merged.

@gopherbot gopherbot closed this Mar 4, 2023
@eiffel-fl
Copy link
Author

Thank you for the reviews and the merge!

@eiffel-fl eiffel-fl deleted the francis/perf-bit-write-backward branch March 6, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eiffel-fl @gopherbot