Skip to content

fix: deduplicate typecheck errors #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 5, 2025

Fixes #5863

to reproduce
version: '2'

issues:
  max-issues-per-linter: 0
  max-same-issues: 0
  uniq-by-line: false
package main

import (
	"context"
)

func main() {
	context.Background(1)
}
$ golangci-lint run
main.go:1: : # github.com/golangci/sandbox
./main.go:8:21: too many arguments in call to context.Background
        have (number)
        want () (typecheck)
package main
...
main.go:1: : # github.com/golangci/sandbox
./main.go:8:21: too many arguments in call to context.Background
        have (number)
        want () (typecheck)
package main
201 issues:
* typecheck: 201

@ldez ldez added this to the v2-unreleased milestone Jun 5, 2025
@ldez ldez added bug Something isn't working area: output Related to issue output labels Jun 5, 2025
@ldez ldez requested a review from bombsimon June 5, 2025 18:22
@ldez ldez changed the title fix: deduplicatiate typecheck errors fix: deduplicate typecheck errors Jun 5, 2025
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ldez
Copy link
Member Author

ldez commented Jun 5, 2025

The CI is stuck I don't know why, I will rebase just relauch it.

@ldez ldez force-pushed the fix/uniq-typecheck branch from 33dc058 to 449efbc Compare June 5, 2025 18:32
@ldez
Copy link
Member Author

ldez commented Jun 5, 2025

there is GitHub issue: https://www.githubstatus.com/

@ldez ldez merged commit 65c85df into golangci:main Jun 5, 2025
18 checks passed
@ldez ldez deleted the fix/uniq-typecheck branch June 5, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: output Related to issue output bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typecheck: Single compiler error results in 200+ identical reports
2 participants