Skip to content

dev: log level colors #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dev: log level colors #5866

wants to merge 1 commit into from

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 7, 2025 •
edited
Loading

Propagate github.com/fatih/color state to the log formatter.

Note: Disabling the colors changes the log format (but it doesn't change the report format).

Color format 
INFO golangci-lint has version (devel) built with go1.24.3 from (unknown, modified: ?, mod sum: "") on (unknown)
No color format 
level=info msg="golangci-lint has version (devel) built with go1.24.3 from (unknown, modified: ?, mod sum: \"\") on (unknown)"

Fixes #5865

@ldez ldez added this to the v2-unreleased milestone Jun 7, 2025
@ldez ldez requested a review from bombsimon June 7, 2025 15:27
@ldez ldez added the area: CLI Related to CLI label Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon Awaiting requested review from bombsimon

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area: CLI Related to CLI
Projects
None yet
Milestone
v2-unreleased
Development

Successfully merging this pull request may close these issues.

--verbose mode doesn't respect --color flag or NO_COLOR env
1 participant
@ldez