ci: linkage monitor CI update to stop using .kokoro/linkage-monitor.sh #1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synthtool's change expects the ci.yaml to use the Linkage Monitor GitHub Actions. (It deletes .kokoro/linkage-monitor.sh) googleapis#1717 However this repository excludes ci.yaml being managed by synthtool. Therefore we need to manually maintain ci.yaml to stop using linkage-monitor.sh.
google-cla
bot
added
the
cla: yes
suztomo
commented
Feb 18, 2021
| @@ -75,7 +75,11 @@ jobs: | |||
| java-version: 8 | |||
| - run: java -version | |||
| - run: .kokoro/install_dependencies.sh | |||
| - run: .kokoro/linkage-monitor.sh | |||
There was a problem hiding this comment.
This is the background of this change. This linkage-monitor.sh is being removed by synthtool (the change in flight). We should use Linkage Monitor GitHub Action ("GoogleCloudPlatform/cloud-opensource-java/linkage-monitor@v1-linkagemonitor")
1 task
elharo
approved these changes
Feb 18, 2021
gcf-owl-bot bot
added a commit
that referenced
this pull request
Nov 28, 2022
chore: upgrade native image checks to graalvm-22.3.0 Source-Link: googleapis/synthtool@5e52896 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:27b1b1884dce60460d7521b23c2a73376cba90c0ef3d9f0d32e4bdb786959cfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1717 ("ci / linkage-monitor" is failing), this change by synthtool expects the ci.yaml
to use the Linkage Monitor GitHub Actions and it deletes .kokoro/linkage-monitor.sh.
However this repository excludes ci.yaml from being managed by synthtool. Therefore we need to manually maintain ci.yaml to stop using linkage-monitor.sh.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️