Skip to content

chore: update docs/dyn #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

chore: update docs/dyn #1137

wants to merge 3 commits into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/f632d5d1-d20c-4ae6-90f5-18e53f0f588a/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/discovery-artifact-manager@0bed8bd
Source-Link: googleapis/synthtool@c2de321

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
Source-Author: Daniel Azuma <[email protected]>
Source-Date: Tue Nov 24 09:22:42 2020 -0800
Source-Repo: googleapis/synthtool
Source-Sha: c2de32114ec484aa708d32012d1fa8d75232daf5
Source-Link: googleapis/synthtool@c2de321
Source-Author: Google APIs <[email protected]>
Source-Date: Wed Nov 25 07:52:04 2020 -0800
Source-Repo: googleapis/discovery-artifact-manager
Source-Sha: 0bed8bdae25d545e796cfcdd7a9bfffff11e69da
Source-Link: googleapis/discovery-artifact-manager@0bed8bd
@yoshi-automation yoshi-automation requested a review from a team as a code owner December 15, 2020 13:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated to pick up changes from self. chore: update docs/dyn Dec 15, 2020
<p class="firstline">Dismisses a request. Returns the updated ApprovalRequest. NOTE: This does not deny access to the resource if another request has been made and approved. It is equivalent in effect to ignoring the request altogether. Returns NOT_FOUND if the request does not exist. Returns FAILED_PRECONDITION if the request exists but is not in a pending state.</p>
<p class="toc_element">
<code><a href="#get">get(name, x__xgafv=None)</a></code></p>
<p class="firstline">Gets an approval request. Returns NOT_FOUND if the request does not exist.</p>
<p class="toc_element">
<code><a href="#list">list(parent, filter=None, pageToken=None, pageSize=None, x__xgafv=None)</a></code></p>
<code><a href="#list">list(filter=None, pageSize=None, pageToken=None, parent, x__xgafv=None)</a></code></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthea It looks like the code might need to be adjusted to keep track of positional v. named args.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'll take a look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in #1141

@busunkim96 busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 15, 2020
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 16, 2020
@parthea parthea closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants