chore: prevent normalization of semver versioning #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
parthea
added
the
do not merge
|
This PR is on hold as @dandhlee confirmed that this requires a minimum version of |
dandhlee
removed
the
do not merge
|
All is good now, if there is no problem with Kokoro pre-submits then it's fine, otherwise I'm working through the repositories to make necessary change and workarounds. |
|
@dandhlee This repo doesn't declare You won't see a failure in CI since the tests will install the latest version of |
|
Understood, will make those changes around! Sorry for that 😓 |
dandhlee
added
the
do not merge
dandhlee
removed
the
do not merge
parthea
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from
-patchto.patchwhich is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.