Skip to content

chore(docs): libraries-bom 24.3.0 in google-http-java-client #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 8, 2022

Libraries BOM 24.3.0 release documentation update in google-http-java-client repository.

@suztomo suztomo requested a review from a team as a code owner February 8, 2022 20:10
@suztomo suztomo added automerege automerge Merge the pull request once unit tests and other checks pass. and removed automerege labels Feb 8, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2022
@suztomo
Copy link
Member Author

suztomo commented Feb 9, 2022

?

Error:  Found 1 non-complying files, failing build
Error:  To fix formatting errors, run "mvn com.coveo:fmt-maven-plugin:format"
Error:  Non complying file: /home/runner/work/google-http-java-client/google-http-java-client/google-http-client/src/test/java/com/google/api/client/http/HttpRequestTracingTest.java

@Neenu1995
Copy link
Contributor

This library has been failing lint for a while now. The solution is to update the java formatter to the version owlbot uses. But we can't update until all librraies have been migrated to owlbot.

@suztomo suztomo merged commit cc1e7b6 into main Feb 9, 2022
@suztomo suztomo deleted the suztomo-patch-2 branch February 9, 2022 22:16
@suztomo
Copy link
Member Author

suztomo commented Feb 9, 2022

Thank you for explanation. Good to see Jeff is reaching the goal of owlbot everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants