Skip to content

revert: "feat: remove opencensus (#834)" #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2019
Merged

revert: "feat: remove opencensus (#834)" #837

merged 1 commit into from
Oct 11, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Oct 11, 2019 •
edited
Loading

@chingor13 chingor13 requested a review from a team as a code owner October 11, 2019 17:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2019
elharo
elharo reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the PR this reverts checked in by accident?

@chingor13
Copy link
Collaborator Author

We can make it an optional dependency before the opentelemetry conversion. So rather than ripping it out and then reimplementing, we can make it defensive in a single PR.

@chingor13 chingor13 merged commit ea09fd5 into googleapis:master Oct 11, 2019
@chingor13 chingor13 deleted the revert branch October 11, 2019 20:54
@abaker abaker mentioned this pull request Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chingor13 @elharo @googlebot