Skip to content

chore: fix various non-functional checkstyle warnings #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2021
Merged

chore: fix various non-functional checkstyle warnings #865

merged 3 commits into from
Oct 8, 2021

Conversation

Anusien
Copy link
Contributor

@Anusien Anusien commented Oct 31, 2019

Fixes the following checkstyle warnings:

[WARN] /home/anusien/opensource/google-http-java-client/google-http-client/src/main/java/com/google/api/client/util/ArrayValueMap.java:14: 'package' should be separated from previous statement. [EmptyLineSeparator]

[WARN] /home/anusien/opensource/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/GZipEncoding.java:45: Empty catch block. [EmptyCatchBlock]

[WARN] /home/anusien/opensource/google-http-java-client/google-http-client/src/main/java/com/google/api/client/testing/util/TestableByteArrayInputStream.java:44:47: Array brackets at illegal position. [ArrayTypeStyle]

@Anusien Anusien requested a review from a team as a code owner October 31, 2019 05:07
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 31, 2019
@elharo elharo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 31, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 31, 2019
@Anusien
Copy link
Contributor Author

Anusien commented Jan 6, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 6, 2020
@chanseokoh chanseokoh changed the title Fix various non-functional checkstyle warnings chore: fix various non-functional checkstyle warnings Oct 8, 2021
@chanseokoh chanseokoh added the automerge Merge the pull request once unit tests and other checks pass. label Oct 8, 2021
@chanseokoh chanseokoh merged commit af0d34f into googleapis:main Oct 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo left review comments

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Anusien @googlebot @elharo @chanseokoh @kokoro-team