-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add x-goog-request-params to header #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
datastore-v1-proto-client/src/main/java/com/google/datastore/v1/client/RemoteRpc.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but check the comment
@@ -46,6 +47,8 @@ class RemoteRpc { | |||
@VisibleForTesting static final String API_FORMAT_VERSION_HEADER = "X-Goog-Api-Format-Version"; | |||
private static final String API_FORMAT_VERSION = "2"; | |||
|
|||
@VisibleForTesting static final String X_GOOG_REQUEST_PARAMS_HEADER = "x-goog-request-params"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me think that we should expose this key as public in gax-java in the future, we have the same key defined here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blakeli0 makes sense! This module doesn't depend on gax, but let me know if you'd like any similar changes here.
I know we probably only need |
@blakeli0 this is an interesting idea - I will file an issue to look into this as a refactor for the future |
This PR consists of cherry picks from the https://github.com/googleapis/java-datastore/tree/multi-db branch. They include: #928 #940 #942 This also enables parameterized testing for ITDatastoreTest.
No description provided.