chore: configure backups test to run in nightly build #1409
Conversation
Add a new JUnit category: SlowTest. It will be used to execute tests that are part of the nightly build. Also refactors the categories hierarchy to be easier to setup.
Configures a profile to execute only the slow tests. It will be invoked in the nightly build.
Sets up the kokoro configuration for running slow tests nightly
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
| <id>default-test</id> | ||
| <configuration> | ||
| <excludedGroups>com.google.cloud.spanner.TracerTest,com.google.cloud.spanner.IntegrationTest</excludedGroups> | ||
| <excludedGroups>com.google.cloud.spanner.categories.TracerTest,com.google.cloud.spanner.categories.IntegrationTest</excludedGroups> |
There was a problem hiding this comment.
You probably need to change the package name for TracerTest further below as well (line 62)
There was a problem hiding this comment.
Ah yes, thanks, fixed it.
| </configuration> | ||
| </execution> | ||
| <execution> | ||
| <id>parallel-integration-test</id> |
There was a problem hiding this comment.
What is the intention with this execution? The name seems to indicate that it will execute parallel integration tests, but if I understand the configuration correctly, it will just skip all tests. Could we maybe add a comment to this section to explain why it's here?
There was a problem hiding this comment.
This is because the default configuration (line 88-98) defines an execution for the integration-test goal with such id. Thus, we need to override it in the slow tests profile to NOOP, otherwise the tests with the category ParallelIntegrationTest will be executed (as per the default one). I added a comment in this section.
The main change of this PR is to move the
ITBackupTestinto a new JUnit category to be executed only on the nightly builds. This is because the Backup test is slow and flaky when executing several in parallel (due to RESOURCE_EXHAUSTED issues). We have done the following here:SlowTestSerialIntegrationTestFlakyTestSlowTest,SerialIntegrationTestandParallelIntegrationTestextend theIntegrationTestcategory (in order to make configuration easier)pom.xmlto run only theSlowTesttestsAddresses #1336