Skip to content

Postgresql Spanner Sample #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Sivakumar-Searce
Copy link
Contributor

  1. Added samples for Postgresql (i.e PgSpannerSample)
  2. Written Integration Tests for the samples
  3. Checked code lints

@Sivakumar-Searce Sivakumar-Searce requested a review from a team as a code owner March 24, 2022 15:16
@google-cla
Copy link

google-cla bot commented Mar 24, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@snippet-bot
Copy link

snippet-bot bot commented Mar 24, 2022

Here is the summary of possible violations 😱

There are 3 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 22 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 24, 2022
@ansh0l
Copy link
Contributor

ansh0l commented Mar 24, 2022

@Sivakumar-Searce : Please template your PR title, description etc based on this PR : #1700. Also, cla is missing, please add it.

Once you do so, I will have a look again.

@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 24, 2022
@ansh0l
Copy link
Contributor

ansh0l commented Mar 24, 2022

cc: @sfogel2 @jin-jj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants