chore: include client statement type in parsed statement #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the ClientSideStatementType in ParsedStatement. This enables clients to directly check what type of statement it is, which removes the need for textual checks.
product-auto-label
bot
added
size: m
ansh0l
reviewed
Apr 27, 2022
| @@ -5,6 +5,7 @@ | |||
| "name": "SHOW VARIABLE AUTOCOMMIT", | |||
| "executorName": "ClientSideStatementNoParamExecutor", | |||
| "resultType": "RESULT_SET", | |||
| "statementType": "SHOW_AUTOCOMMIT", | |||
There was a problem hiding this comment.
nit: we seem to have added extra indentation to all modified lines in this file, please check.
There was a problem hiding this comment.
Hmmm... That file needs a small cleanup. It uses both tabs AND spaces for indentation (first indentation is one tab, then second indentation is two spaces).
I've made this change consistent with the current format of the file. Let's do the cleanup in a separate PR.
…/java-spanner into include-client-statement-type
olavloite
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the ClientSideStatementType in ParsedStatement. This enables
clients to directly check what type of statement it is, which removes
the need for textual checks.
This will for example remove these types of checks: https://github.com/GoogleCloudPlatform/pgadapter/blob/2a3f2eb7cd16cc3c71ffc673544ca9e2baaba21c/src/main/java/com/google/cloud/spanner/pgadapter/statements/IntermediateStatement.java#L354