Skip to content

feat: Adding support for databoost #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ implementation 'com.google.cloud:google-cloud-spanner'
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-spanner:6.45.1'
implementation 'com.google.cloud:google-cloud-spanner:6.45.2'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.45.1"
libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.45.2"
```
<!-- {x-version-update-end} -->

Expand Down Expand Up @@ -430,7 +430,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-spanner/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-spanner.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-spanner/6.45.1
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-spanner/6.45.2
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.google.cloud.spanner;

import com.google.api.core.BetaApi;
import com.google.common.base.Preconditions;
import com.google.spanner.v1.RequestOptions.Priority;
import java.io.Serializable;
Expand Down Expand Up @@ -156,11 +155,9 @@ public static ListOption pageSize(int pageSize) {
}

/**
* If this is for a partitioned read and query and this field is set to `true`, the request will
* be executed via Spanner independent compute resources. The method is available in Beta mode
* (and is not generally available now).
* If this is for PartitionedRead or PartitionedQuery and this field is set to `true`, the request
* will be executed via Spanner independent compute resources.
*/
@BetaApi
public static DataBoostQueryOption dataBoostEnabled(Boolean dataBoostEnabled) {
return new DataBoostQueryOption(dataBoostEnabled);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,6 @@ public void readUsingIndex() {

@Test
public void dataBoostRead() {
// TODO: Remove the following check during GA
assumeFalse("DataBoost feature is not yet generally available", true);
assumeFalse("Emulator does not support data boost read", isUsingEmulator());

BitSet seenRows = new BitSet(numRows);
Expand Down Expand Up @@ -314,8 +312,6 @@ private PartitionOptions getRandomPartitionOptions() {

@Test
public void dataBoostQuery() {
// TODO: Remove the following check during GA
assumeFalse("DataBoost feature is not yet generally available", true);
assumeFalse("Emulator does not support data boost query", isUsingEmulator());
BitSet seenRows = new BitSet(numRows);
TimestampBound bound = getRandomBound();
Expand Down