-
Notifications
You must be signed in to change notification settings - Fork 132
ci: javadoc job (JDK 17) in ci.yaml (#1819) #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arpan14
merged 3 commits into
main
from
owl-bot-update-lock-31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9
Jul 21, 2023
Merged
ci: javadoc job (JDK 17) in ci.yaml (#1819) #2515
arpan14
merged 3 commits into
main
from
owl-bot-update-lock-31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9
Jul 21, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9
Errors: https://github.com/googleapis/java-spanner/actions/runs/5394815252/jobs/9796509445?pr=2515
@arpan14 Would you fix the invalid Javadoc in this library? It's not urgent. If it's too much, I can take care of them. The warnings are just warnings. Focus on fixing "errors: ". |
Merged
It still shows errors.
|
suztomo
approved these changes
Jul 20, 2023
464393f
to
ed05dea
Compare
arpan14
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
owl-bot-update-lock
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
Source-Link: googleapis/synthtool@ef9fe2e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9