Skip to content

chore: add a random channel hint with single use transactions while u… #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2024
Merged

chore: add a random channel hint with single use transactions while u… #3065

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ce399a
chore: add a random channel hint with single use transactions while u…
arpan14 Apr 26, 2024
b6f4aa4
Merge branch 'googleapis:main' into mux-pr-random-hint
arpan14 Apr 29, 2024
64d1769
chore: rephrase comments.
arpan14 Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,11 @@ private SingleReadContext(Builder builder) {
this.bound = builder.bound;
// single use transaction have a single RPC and hence there is no need
// of a channel hint. GAX will automatically choose a hint when used
// with a multiplexed session.
this.channelHint = getChannelHintOptions(session.getOptions(), null);
// with a multiplexed session to perform a round-robin channel selection. We are
// passing a hint here to prefer random channel selection instead of doing GAX round-robin.
this.channelHint =
getChannelHintOptions(
session.getOptions(), ThreadLocalRandom.current().nextLong(Long.MAX_VALUE));
}

@Override
Expand Down