Skip to content

test: do not use RESOURCE_EXHAUSTED as it is retryable #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

olavloite
Copy link
Collaborator

The test used the error code RESOURCE_EXHAUSTED to indicate that the server could not create any more sessions. This error code is now retryable, causing the test to become flaky. Change the error code to one that is not retryable.

Fixes #3224

The test used the error code RESOURCE_EXHAUSTED to indicate that
the server could not create any more sessions. This error code is
now retryable, causing the test to become flaky. Change the error
code to one that is not retryable.

Fixes #3224
@olavloite olavloite requested a review from a team as a code owner July 29, 2024 12:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Jul 29, 2024
@olavloite olavloite merged commit c4c09dc into main Jul 29, 2024
33 of 34 checks passed
@olavloite olavloite deleted the issue-3224 branch July 29, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchCreateSessionsTest is flaky
2 participants