chore(spanner): Implement fallback for multiplexed session on Partitioned Operations #3631
Conversation
pratickchokhani
commented
Feb 10, 2025
pratickchokhani
commented
- handle server side kill switch for multiplexed sessions with Partitioned Ops.
…oned Operations - handle server side kill switch for multiplexed sessions with Partitioned Ops.
product-auto-label
bot
added
size: m
… for narrowing down initial validation.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BatchClientImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| void maybeMarkUnimplementedForPartitionedOps(SpannerException spannerException) { | ||
| if (spannerException.getErrorCode() == ErrorCode.INVALID_ARGUMENT |
There was a problem hiding this comment.
Are you sure that the error code will be INVALID_ARGUMENT (and not UNIMPLEMENTED)?
There was a problem hiding this comment.
Yes, for Partitioned Read or Query, we are returning INVALID_ARGUMENT.
There was a problem hiding this comment.
@pratickchokhani
As discussed in the meeting, can we temporarily remove the error code check?
Context:
We plan to update the backend to return the UNIMPLEMENTED error for partitioned operations. However, this change will not be part of the current release and will be introduced in a follow-up update.
If we proceed with this error code check now, it will break backward compatibility when the backend starts returning UNIMPLEMENTED. To avoid this issue, we are removing the check for now and will reintroduce it once the backend update is complete.
cc: @rahul2393 to do the same for golang.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BatchClientImpl.java
Outdated
Show resolved
Hide resolved
…hani/java-spanner into mux-partitioned-ops-fallback
|
@pratickchokhani |
…ssion fallback in Partitioned Operations.
…to mux-partitioned-ops-fallback
