Skip to content

test: cleanup AsyncResultSetImplTest #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

olavloite
Copy link
Collaborator

Cleans up some warnings and a leaked thread that was not stopped in one of the tests. The actual flaky test was probably fixed as part of the refactor of async queries, and is no longer reproducible.

Closes #3365

Cleans up some warnings and a leaked thread that was not stopped in one
of the tests. The actual flaky test was probably fixed as part of the
refactor of async queries, and is no longer reproducible.

Closes #3365
@olavloite olavloite requested review from a team as code owners March 18, 2025 15:40
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 18, 2025
@olavloite olavloite merged commit 23c6449 into main Mar 18, 2025
34 of 35 checks passed
@olavloite olavloite deleted the cleanup-async-result-set-impl-test branch March 18, 2025 17:39
@suztomo suztomo mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncResultSetImplTest.testCallbackIsNotCalledWhilePausedAndCanceled is flaky
2 participants