Skip to content

chore: support UUID in Cloud Client Executor #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2025
Merged

chore: support UUID in Cloud Client Executor #3841

merged 4 commits into from
May 21, 2025

Conversation

gagangupt16
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Apr 29, 2025
@gagangupt16 gagangupt16 marked this pull request as ready for review April 29, 2025 08:41
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Apr 29, 2025
@gagangupt16 gagangupt16 requested review from a team as code owners April 29, 2025 08:41
sachinagargoogle
sachinagargoogle approved these changes Apr 29, 2025
View reviewed changes
Copy link

@sachinagargoogle sachinagargoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run UUID systest with CloudClientProxy to validate the changes or any other e2e randomized unit test.

@gagangupt16 gagangupt16 force-pushed the uuid_cloud_client_executor branch from f96fef1 to be9bedb Compare May 6, 2025 04:59
@gyang-google
Copy link
Contributor

LGTM

@gagangupt16 gagangupt16 force-pushed the uuid_cloud_client_executor branch from be9bedb to 2c5508d Compare May 20, 2025 06:26
@rahul2393 rahul2393 merged commit 9424d32 into googleapis:main May 21, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

@gyang-google gyang-google gyang-google approved these changes

@sachinagargoogle sachinagargoogle sachinagargoogle approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gagangupt16 @gyang-google @rahul2393 @sachinagargoogle