chore(x-goog-spanner-request-id): enable tests for more RPCs #3898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
odeke-em
force-pushed
the
x-goog-spanner-request-id+round-2-plumbing
branch
3 times, most recently
from
91ec136 to
427ad07
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id+round-2-plumbing
branch
from
427ad07 to
efa5fac
Compare
odeke-em
force-pushed
the
x-goog-spanner-request-id+round-2-plumbing
branch
2 times, most recently
from
6de2b89 to
abe982f
Compare
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 22, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 22, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 23, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 23, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 26, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
olavloite
pushed a commit
that referenced
this pull request
Jun 27, 2025
…s prior code review suggestions (#3922) * chore(x-goog-spanner-request-id): propagate reqId into exceptions plus prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR #3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR #3898 and PR #3915 * Update tests with session.getRequestIdCreator * More plumbing * Update tests * Deal with the multiplex-session .getOptions null returns in getChannel * Correct array copy
odeke-em
force-pushed
the
x-goog-spanner-request-id+round-2-plumbing
branch
from
7449771 to
675c5de
Compare
product-auto-label
bot
added
size: s
Enable asserting that all the Spanner Method RPCs have x-goog-spanner-request-id. Updates googleapis#3537
odeke-em
changed the title
odeke-em
force-pushed
the
x-goog-spanner-request-id+round-2-plumbing
branch
from
675c5de to
430c098
Compare
|
@olavloite @rahul2393 @sakthivelmanii kindly help me run the bots for this PR. |
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Jun 28, 2025
Comment on lines
1101
to
1103
| if (this.reqId == null || other.reqId == null) { | ||
| return this.reqId == null && other.reqId == null; | ||
| } |
There was a problem hiding this comment.
nit: you can remove this as well when you use Objects.equals(...) (feel free to do in a following PR)
Suggested change
| if (this.reqId == null || other.reqId == null) { | |
| return this.reqId == null && other.reqId == null; | |
| } |
sakthivelmanii
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable asserting that all the Spanner Method RPCs have
x-goog-spanner-request-id.
Updates #3537