BUG: Explicitly use 64bit integers when converting from BQ types #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 64-bit windows 10 the `int` values are cast into 32-bit integers for reasons given here https://stackoverflow.com/questions/36278590/numpy-array-dtype-is-coming-as-int32-by-default-in-a-windows-10-64-bit-machine This leads to unhanded exceptions when handling values beyond 32-bit signed range In Bigquery, int is always 64bit, so the solution is to specify the data type explicitly
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
===========================================
- Coverage 75.7% 30.99% -44.72%
===========================================
Files 8 8
Lines 1626 1626
===========================================
- Hits 1231 504 -727
- Misses 395 1122 +727
Continue to review full report at Codecov.
|
blose
changed the title
|
I think that looks good! Thanks! I don't think there's a helpful test we could add, given we don't test on Windows - @tswast ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issue #119
On 64-bit windows 10 the
intvalues are cast into 32-bit integers for reasons given herehttps://stackoverflow.com/questions/36278590/numpy-array-dtype-is-coming-as-int32-by-default-in-a-windows-10-64-bit-machine
This leads to unhandled exceptions when handling values beyond 32-bit signed range
In Bigquery, int is always 64bit, so the solution is to specify the data type explicitly