Skip to content

add @stickler-ci #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2018
Merged

add @stickler-ci #141

merged 1 commit into from
Mar 4, 2018

Conversation

max-sixty
Copy link
Contributor

@max-sixty max-sixty commented Mar 3, 2018

We've got this running in xarray, and it's pretty good - much nicer to get a PR comment before the travis fail.

pydata/xarray#1913

One question is whether we want it adding changes automatically, in addition to the standard PR comments. I thought it was good but others didn't, so we decided to turn it off there. I've enabled it here, but open-minded.

Someone with commit privileges needs to start it checking here: https://stickler-ci.com/repositories

@codecov-io
Copy link

codecov-io commented Mar 3, 2018

Codecov Report

Merging #141 into master will decrease coverage by 44.7%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #141       +/-   ##
===========================================
- Coverage   75.62%   30.92%   -44.71%     
===========================================
  Files           8        8               
  Lines        1633     1633               
===========================================
- Hits         1235      505      -730     
- Misses        398     1128      +730
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 26.78% <0%> (-56.64%) ⬇️
pandas_gbq/gbq.py 20.56% <0%> (-55.8%) ⬇️
pandas_gbq/_load.py 62.5% <0%> (-35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1155958...66a9218. Read the comment docs.

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks helpful. Thanks @maxim-lian !

@parthea
Copy link
Contributor

parthea commented Mar 4, 2018

I'm going to merge this so we can try it out.

@parthea parthea merged commit 1674760 into googleapis:master Mar 4, 2018
@max-sixty max-sixty deleted the stickler branch March 4, 2018 17:26
@max-sixty
Copy link
Contributor Author

@parthea can you enable it here: https://stickler-ci.com/repositories or give me permissions to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants