Skip to content

bump google auth version #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 1, 2018
Merged

Conversation

max-sixty
Copy link
Contributor

Closes #73

@parthea
Copy link
Contributor

parthea commented Mar 4, 2018

Could we upgrade to the latest version of google-auth to take advantage of the latest fixes? The latest version 1.4.1 might also fix #136 . I see a note in the google-auth release notes that says 'default() now checks for the project ID environment var before warning about missing project ID.'

@max-sixty
Copy link
Contributor Author

Yes, to be clear, we want to make that a min version?

@stickler-ci
Copy link

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@codecov-io
Copy link

codecov-io commented Mar 4, 2018

Codecov Report

Merging #143 into master will decrease coverage by 40.62%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #143       +/-   ##
===========================================
- Coverage   75.48%   34.85%   -40.63%     
===========================================
  Files           8        8               
  Lines        1534     1529        -5     
===========================================
- Hits         1158      533      -625     
- Misses        376      996      +620
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 28.08% <0%> (-56.25%) ⬇️
pandas_gbq/gbq.py 30.76% <0%> (-45.38%) ⬇️
pandas_gbq/_load.py 62.5% <0%> (-35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac22f4...9edd609. Read the comment docs.

@max-sixty max-sixty changed the title bump google auth verison to 1.0.2 bump google auth version Mar 4, 2018
@max-sixty
Copy link
Contributor Author

@parthea gentle ping

setup.py Outdated
@@ -18,7 +18,7 @@ def readme():

INSTALL_REQUIRES = [
'pandas',
'google-auth>=1.0.0',
'google-auth>=1.4.1',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not so sure about bumping up a dependency version here just for upstream bug fixes. This is technically a breaking change and I know it would cause some hurt inside Google, which is ironically slow to make version upgrades of these packages.

We should keep our CI and this in sync, though. What was the reason for bumping the version to 1.0.2 in #139 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast @maxim-lian
How do you feel about removing pinning altogether ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more okay with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - let's do that

I think we can then refer those issues (#73 and #136) upstream - they're not pandas-gbq specific. Is that right?

@max-sixty
Copy link
Contributor Author

Updated!

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxim-lian !

@parthea parthea merged commit 27d5d11 into googleapis:master Apr 1, 2018
@max-sixty max-sixty deleted the bump-google-auth branch April 1, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants