-
Notifications
You must be signed in to change notification settings - Fork 125
bump google auth version #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could we upgrade to the latest version of |
Yes, to be clear, we want to make that a min version? |
I couldn't find a |
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
===========================================
- Coverage 75.48% 34.85% -40.63%
===========================================
Files 8 8
Lines 1534 1529 -5
===========================================
- Hits 1158 533 -625
- Misses 376 996 +620
Continue to review full report at Codecov.
|
@parthea gentle ping |
setup.py
Outdated
@@ -18,7 +18,7 @@ def readme(): | |||
|
|||
INSTALL_REQUIRES = [ | |||
'pandas', | |||
'google-auth>=1.0.0', | |||
'google-auth>=1.4.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not so sure about bumping up a dependency version here just for upstream bug fixes. This is technically a breaking change and I know it would cause some hurt inside Google, which is ironically slow to make version upgrades of these packages.
We should keep our CI and this in sync, though. What was the reason for bumping the version to 1.0.2 in #139 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tswast @maxim-lian
How do you feel about removing pinning altogether ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be more okay with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maxim-lian !
Closes #73